Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try building without the System.Xml.ReaderWriter nuget package reference #251

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

Numpsy
Copy link

@Numpsy Numpsy commented Sep 11, 2022

Hi,

I was doing some tests with AvaloniaEdit and Avalonia.FuncUI and wondered if the System.Xml.ReaderWriter nuget package reference is needed when targetting netstandard2.0 (System.Xml being built in to that version).

(Reasoning: the security tools at work like to complain about indirect references to old versions of System.Text.RegularExpressions that have security vulnerabilities and I got in a habbit of removing old references if they don't seem to be required any more)

@dnfadmin
Copy link

dnfadmin commented Sep 11, 2022

CLA assistant check
All CLA requirements met.

@danipen danipen merged commit 66cd783 into AvaloniaUI:master Sep 19, 2022
@Numpsy Numpsy deleted the rw/no_xml_readerwriter branch September 21, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants