Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling adjustments #354

Merged
merged 8 commits into from
Aug 31, 2023
Merged

Styling adjustments #354

merged 8 commits into from
Aug 31, 2023

Conversation

maxkatz6
Copy link
Member

Continuing #194

Changes:

  1. Cleanup: replaced "clr-assembly:" with "using:"
  2. Instead of adding a style on every ContentControl, introduced CompletionTipContentControl type specifically for auto-completion tooltip content.
  3. Removed VisualLineDrawingVisual style as it seems to do nothing. Cursor property is inheritable and in the demo app cursor on inline controls works as expected. @danipen please let me know if I am wrong here.
  4. Made internal xaml files actually internal, so they can't be accessed directly with ResourceInclude, and so they can be merged together into a single dictionary
  5. Introduced OverloadViewer*** and TextAreaSelectionBrush brushes to fix insight window theming
  6. Restructured Base, Fluent and Simple files, so Base one can be used directly without referencing any specific theme. User just need to define brushes as they expect.

@maxkatz6 maxkatz6 requested a review from danipen July 15, 2023 04:01
@maxkatz6 maxkatz6 requested a review from a team August 29, 2023 09:17
@maxkatz6
Copy link
Member Author

Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxkatz6 maxkatz6 merged commit 6821c5d into master Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants