Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling by mouse selection #390

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Fix scrolling by mouse selection #390

merged 6 commits into from
Jan 8, 2024

Conversation

KrzysztofDusko
Copy link
Contributor

more details :
#388

danipen
danipen requested changes Jan 8, 2024
View reviewed changes
src/AvaloniaEdit/Search/SearchPanel.cs Outdated Show resolved Hide resolved
src/AvaloniaEdit/Editing/SelectionMouseHandler.cs Outdated Show resolved Hide resolved
KrzysztofDusko and others added 3 commits January 8, 2024 17:27
@KrzysztofDusko @danipen
Update src/AvaloniaEdit/Editing/SelectionMouseHandler.cs
4108641 
Co-authored-by: Daniel Peñalba <daniel.penalba@unity3d.com>
@KrzysztofDusko
fix for 4108641
7ca6468
@KrzysztofDusko
fix
452b8a8
@danipen
Copy link
Collaborator

danipen commented Jan 8, 2024

I verified that both scenarios where ExtendSelectionToMouse is called work as expected. When selecting text and when performing rectangular selection with the option ExtendSelectionOnMouseUp enabled.

Also, editing in the edges still preserves the scroll position so all works as expected.

@danipen danipen merged commit 09b0c9a into AvaloniaUI:master Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danipen danipen danipen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrzysztofDusko @danipen