Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overstrike mode #415

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

mgarstenauer
Copy link
Contributor

This PR enables Overstrike mode (in other editors called OVR, Overwrite, Overtype), which is not yet working.

Simply uncommenting the code in TextArea.cs solves the problem. All relevant code paths for Overstrike from AvalonEdit are already present in AvaloniaEdit.

Instruction for testing:

  • Run AvaloniaEdit.Demo.
  • Press Insert (ins) key on the keyboard.

Expected behavior:

  • The caret changes from a line to block.
  • Typing now overwrites the right characters instead of inserting characters at the caret position.

Copy link
Collaborator

@danipen danipen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danipen danipen merged commit 4207cbe into AvaloniaUI:master Apr 19, 2024
3 checks passed
@mgarstenauer mgarstenauer deleted the enable-overstrike-mode branch April 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants