feat: auto-completition with generics #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantvc
requested changes
Oct 30, 2023
| @@ -529,6 +526,68 @@ IEnumerable<string> filterNamespaces(Func<string, bool> predicate) | |||
| return new CompletionSet() { Completions = SortCompletions(completions), StartPosition = curStart }; | |||
|
|
|||
| return null; | |||
|
|
|||
| static (string DisplayText, string InsertText, string? Suffix, int? RecommendedCursorOffset, bool TriggerCompletionAfterInsert) GetElementCompletation(string key, | |||
There was a problem hiding this comment.
This method is too big to be a local, could you move it out?
Also, I suggest against tuple for return types, makes it difficult to read the code.
prashantvc
approved these changes
Oct 31, 2023
workgroupengineering
deleted the
features/Intellisense/Generics-Completition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only resolve #356. After thi PR merger will work on #357
Before
After
Depends on PR 409
Fixes #356
Part of AvaloniaUI/AvaloniaVSCode#8