Add GetSourceProjectSafe #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Our solution contains a number of .csproj and .vcxproj files. A recent change to our own .vcxproj files suddenly caused the Avalonia design preview to fail when
Reference.SourceProjectwas being accessed inSolutionService.cs. These failures showed up as either COM errors or as NotImplementedException (depending on the .vcxproj).Despite the Avalonia design preview's failure, our solution would build correctly and we could correctly run our Avalonia desktop application.
To resolve the issue, we implemented the changes in this PR and installed a locally built version of AvaloniaVS.VS2022.vsix. The Avalonia design preview is now working correctly in our solution with this fix.
Testing