Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode-avalonia): prompt users to choose a solution file if workspace contains multiple #104

Closed
wants to merge 1 commit into from

Conversation

BinToss
Copy link
Contributor

@BinToss BinToss commented Feb 9, 2024

Resolves #101

Note: commented code will not work until tc39/proposal-explicit-resource-management is formally part of ES. The commented code can be compiled with ESNext, but won't run in supported in VSCode <= v1.86.1

…space contains multiple

Commented code will not work until tc39/proposal-explicit-resource-management formally part of the ES. It can be compiled with ESNext, but it not supported in VSCode's runtime.
@prashantvc prashantvc self-requested a review February 9, 2024 08:31
@prashantvc
Copy link
Collaborator

Can you elaborate how this feature works please? I mean as a avalonia developer how will use this feature

@BinToss
Copy link
Contributor Author

BinToss commented Feb 10, 2024

Currently, if the workspace contains several Solution files, the extension selects the first one it finds (SolutionA) and passes it to the SolutionParser.
There's a chance SolutionA does not have any WinExe projects by design.
However, a WinExe project may exist in SolutionB, SolutionC, et cetera.

This change allows the user to choose which Solution file should be passed to SolutionParser.


On that note, perhaps every solution file should be parsed and filtered for Solutions which include the current document. Only then should the user be prompted.

@prashantvc
Copy link
Collaborator

Sounds goo. Could you fix the review comments? I will merge once you do it :)

@BinToss
Copy link
Contributor Author

BinToss commented Mar 19, 2024

I don't see any review comments to resolve.

@BinToss BinToss closed this Mar 19, 2024
@BinToss BinToss deleted the fix-issue-101 branch March 19, 2024 08:42
@BinToss
Copy link
Contributor Author

BinToss commented Mar 19, 2024

I accidentally deleted the wrong branch and I'm unable to re-open the pull request. I have to create a new one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSolutionFile silently selects the first solution when multiple are found
2 participants