Use IDotnetAcquireResult for dotnet.findPath result #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See breaking change in vscode-dotnet-runtime: https://github.com/dotnet/vscode-dotnet-runtime/blob/814208c72c9ecbfdc0d979c486eddfd3915e0b3e/vscode-dotnet-runtime-extension/CHANGELOG.md?plain=1#L22 The `findPath` command now returns a `IDotnetAcquireResult` object instead of a string. The string containing the actual path is in the `dotnetPath` property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See breaking change in vscode-dotnet-runtime:
https://github.com/dotnet/vscode-dotnet-runtime/blob/814208c72c9ecbfdc0d979c486eddfd3915e0b3e/vscode-dotnet-runtime-extension/CHANGELOG.md?plain=1#L22
The
findPathcommand now returns aIDotnetAcquireResultobject instead of a string. The string containing the actual path is in thedotnetPathproperty. With the current code, the result was an "unsupported server configuration" error when starting the LSP client. This PR fixes the error.