How to show and hide a split view pane with mvvm guide #537
Conversation
I guess github does not like empty directories
…ing a pull request.
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Adding content to the button | ||
| Finally, you now just need to add some content to the button that indicates whether you need to show or hide the SplitView's pane. In this guide we will be using the following characters: |
There was a problem hiding this comment.
Does the button really need to have it's content changed? It seems somewhat superfluous to the main point of the guide, which is showing how to control the open/close state of the split view.
There was a problem hiding this comment.
I think it's something people that looks around for this guide might want to do.
There was a problem hiding this comment.
I think it should be its own separate section then as an "advanced" thing. Otherwise it's just conflating two different concepts together.
There was a problem hiding this comment.
By separate section do you mean in the same document or another one?
There was a problem hiding this comment.
Either is fine with me. One of the Avalonia devs may say something else.
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
|
I have added some things I think should be addressed. But to be clear: I am not an Avalonia dev so it's also not really up to me either. |
Hey, thank you so much for the time! This is my fisrt time trying to contribute to a repository, and every advice or constructive criticism is always welcome! Just one question: to make a framework agnostic approach do you think it's ok to have a section with Using ReactiveUI and another with "Using INotifypropertyChanged"? |
Some things still needs to be checked and fixed, but the majority is done. Or at least it should be.
Thank you for the PR, and welcome. It's appreciated!
That's fine with me. |
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
|
Hello @Nemonek first of all thank you for the contribution. However I have one idea to make this sample even easier to explore. We have https://github.com/AvaloniaUI/Avalonia.Samples where we want to create tutorials and detialed samples. These can be linked from the docs. Benefit is that anyone can just grab the source, download it and play around. From what I see your sample would fit perfectly here. What do you think? |
…matical errors. Clarified the namespace usage in the code. To do the part with the framework agnostic approach.
|
Alright, so, I fixed some things that were to be done, and I also added the parts with the framework agnosti approach as suggested. |
|
I think both would be fine. Make it a draft PR for now as I may want to feedback about the sample beforehand. I'm thinking about a Hamburger Menu like solution for the demo, could be under custom controls. What I don't understand is why we use a button instead of a togglebutton. A toggleButton can just be bound to IsChecked and we are there without much hassle. This is why I want to see your sample life to understand what may improve. |
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Adding content to the button | ||
| Finally, you now just need to add some content to the button that indicates whether you need to show or hide the SplitView's pane. In this guide we will be using the following characters: |
There was a problem hiding this comment.
I think it should be its own separate section then as an "advanced" thing. Otherwise it's just conflating two different concepts together.
|
Ok, after playing a bit with Github desktop I managed to fork the repository. Anyway, I uploaded both the projects in the same directory as the main solution, as I don't know if you want to put those in the MVVM folder or another. Here's the link. For what regards the toggle button, well, I hadn't tought of that; sure it would be better and especially simpler to use that, as there wouldn't even be the need for a command. Just a simple binding. Let me know what should be modified and I'll take care of it! |
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
docs/guides/development-guides/how-to-show-and-hide-a-split-view-pane-with-mvvm.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Adding content to the button | ||
| Finally, you now just need to add some content to the button that indicates whether you need to show or hide the SplitView's pane. In this guide we will be using the following characters: |
There was a problem hiding this comment.
Either is fine with me. One of the Avalonia devs may say something else.
Hey, I've been looking around the Avalonia docs for a while and I spotted this guide with written "to do". I kept an eye on it for a while and I decided to write it. So here's my pull requeste. I hope everything is in order.