Update opening-a-dialog.md #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.NullReferenceException: Object reference not set to an instance of an object." 10:09:51.696 [Error] 18512 <= " at Avalonia.MusicStore.Views.MainWindow.<.ctor>b__0_0(Action1 action) in Avalonia.MusicStore\Views\MainWindow.axaml.cs:line 14" Either ensure that ViewModel is not nullable or add data context in constructor: DataContext = new MainWindowViewModel();
|
The view model is nullable. The code that is there just assumes it never will be, which it wont 99% of the time. The only time it should be null is if you for some reason create the dialogue without giving it a view model. In fact: adding this check may actually create additional bugs since it will silently fail to register interaction handlers when the view is activated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.NullReferenceException: Object reference not set to an instance of an object."
10:09:51.696 [Error] 18512 <= " at Avalonia.MusicStore.Views.MainWindow.<.ctor>b__0_0(Action1 action) in Avalonia.MusicStore\Views\MainWindow.axaml.cs:line 14"
Either ensure that ViewModel is not nullable or add data context in constructor: DataContext = new MainWindowViewModel();