Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update displaying-images.md #552

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update displaying-images.md #552

wants to merge 1 commit into from

Conversation

Simusharp
Copy link
Contributor

There is a typo in the logic; it should IsVisible when IsNotNull

@Simusharp
Update displaying-images.md
5a9fbaf 
There is a typo in the logic; it should IsVisible when IsNotNull
@djeikyb
Copy link

djeikyb commented Oct 23, 2024 •
edited
Loading

@Simusharp Are you sure about this change?

  1. This whole section is designed to teach IsNull as an intro to converters. This is not a typo-level mistake. It'd be surprising if it was this wrong for this long.
  2. If the IsNull in the code block is wrong, then it's probably also wrong in the paragraph that references the code block. You changed the code block but didn't address any of the corresponding tutorial text.
  3. Did you test this code change? I don't think there's any automation for testing tutorial code blocks, but it'd be good to know if you've validated the PR by running the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simusharp @djeikyb