ViewLocator param name should follow the interface #277
Conversation
| var control = (Control)Activator.CreateInstance(type)!; | ||
| control.DataContext = data; | ||
| return control; | ||
| return (Control)Activator.CreateInstance(type)!; | ||
| } |
There was a problem hiding this comment.
Hey, is there a reason for making this change? The F# template still has the previous default behavior (which I personally prefer)
There was a problem hiding this comment.
This change was made to match our other template: https://github.com/AvaloniaUI/avalonia-dotnet-templates/blob/main/templates/csharp/xplat/AvaloniaTest/ViewLocator.cs
Also, hardcoding DataContext in this code potentially can be problematic. Typically, DataContext should be inherited from parent instead.
There was a problem hiding this comment.
I didn't change F# template, as I can't confidently code in F# or test it.
If you think it should also be updated in any way, and can test it, please open a PR, I can review it at least.
There was a problem hiding this comment.
Yeah, this makes sense, thanks for getting back to me. I was so happy about being a (somewhat real) contributor with #238 but I understand your reasoning.
Closes #269