-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ceaser Cipher Conversion Project #127
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Damini2004 I think cipher.css
and style.css
have same code.
So, remove 1 file.
And follow the structure and guidelines mentioned in CONTRIBUTING.md
file.
If you feel any queries, go through successful merged prs of Front-end-Projects
OK.
Front-end-Projects/Intermediate/Ceaser Cipher/ceaser_cipher.html
Outdated
Show resolved
Hide resolved
Hello sir @Avdhesh-Varshney No sir Style.css and cipher.css contain different program that if user want dark theme then style.css will run and if user want light theme cipher.css will run. So kindly check the commit 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Damini2004 Everything is perfect.
But i have told for reviewing because you have not read guidelines properly.
- You have not properly linked your issue with PR.
- Change directory name to
Ceaser-Cipher
. - And add a screenshot with extension of webp as
screenshot.webp
. - Also you have included a
README.md
file.
Now, if you have any query, either go through merged PR's or tag me in GSSOC server.
Ceaser Cipher Conversion Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See this PR is perfect LINK
- I have provided you name with a hyphen and told you to read guidelines carefully.
- Still you have not attach 1 screenshot which have extension of webp format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow this README TEMPLATE.
@Damini2004 There is a suggestion to you.
And there is a request to you, because of my fault, i had attach the front-end-projects label with this project but it is a vanilla-js-project. So, cut paste the project and resolve the above errors, commit all the changes in 1 go. |
Project Ceaser Cipher Conversion Project #127
Pull Request for WebMasterLog 💡
Ceaser Cipher Conversion Project
Issue Title: Ceaser Cipher conversion
Closes: #124
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
I have added the algorithm via which we can easily convert the text.
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Checklist: ☑️
Screenshots 📷
Uploading freecompress-Caesar Cipher and 7 more pages - Personal - Microsoft_ Edge 2024-05-12 04-14-06.mp4…
Note to reviewers 📄
I generally designed the UI of ceaser cipher in basic format because the main concept behind the ceaser cipher is its conversion of text as per the keys. I posted commit in Frontend intermediate project.Kindly gothrough and suggest any improvement.