Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceaser Cipher Conversion Project #127

Closed
wants to merge 6 commits into from

Conversation

Damini2004
Copy link
Contributor

@Damini2004 Damini2004 commented May 11, 2024

Pull Request for WebMasterLog 💡

Ceaser Cipher Conversion Project

Issue Title: Ceaser Cipher conversion

Closes: #124

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
I have added the algorithm via which we can easily convert the text.

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

dark
light

Uploading freecompress-Caesar Cipher and 7 more pages - Personal - Microsoft_ Edge 2024-05-12 04-14-06.mp4…

Note to reviewers 📄

I generally designed the UI of ceaser cipher in basic format because the main concept behind the ceaser cipher is its conversion of text as per the keys. I posted commit in Frontend intermediate project.Kindly gothrough and suggest any improvement.

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:07pm

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Damini2004 I think cipher.css and style.css have same code.
So, remove 1 file.
And follow the structure and guidelines mentioned in CONTRIBUTING.md file.
If you feel any queries, go through successful merged prs of Front-end-Projects OK.

@Damini2004
Copy link
Contributor Author

Damini2004 commented May 12, 2024

Hello sir @Avdhesh-Varshney No sir Style.css and cipher.css contain different program that if user want dark theme then style.css will run and if user want light theme cipher.css will run.
As you mentioned to format the html document,and rremove unnecessary javascript program i have resolve that issue.

So kindly check the commit 3

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Damini2004 Everything is perfect.
But i have told for reviewing because you have not read guidelines properly.

  • You have not properly linked your issue with PR.
  • Change directory name to Ceaser-Cipher.
  • And add a screenshot with extension of webp as screenshot.webp.
  • Also you have included a README.md file.

Now, if you have any query, either go through merged PR's or tag me in GSSOC server.

@Avdhesh-Varshney Avdhesh-Varshney changed the title Ceaser Cipher Work has been done Ceaser Cipher Conversion Project May 12, 2024
@Damini2004
Copy link
Contributor Author

Damini2004 commented May 12, 2024

Ceaser Cipher Conversion Project

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Damini2004

  • See this PR is perfect LINK
  • I have provided you name with a hyphen and told you to read guidelines carefully.
  • Still you have not attach 1 screenshot which have extension of webp format.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow this README TEMPLATE.

@Avdhesh-Varshney
Copy link
Owner

@Damini2004 There is a suggestion to you.

  • If time exceedes more than 24 hrs, drop a msg in GSSOC server to either mentors or project admin (me) and
  • review the edited template of PR what i have changed for future contributions.

And there is a request to you, because of my fault, i had attach the front-end-projects label with this project but it is a vanilla-js-project. So, cut paste the project and resolve the above errors, commit all the changes in 1 go.

Avdhesh-Varshney added a commit that referenced this pull request May 17, 2024
Project Ceaser Cipher Conversion Project #127
@Avdhesh-Varshney Avdhesh-Varshney added wontfix ❌ This will not be worked on gssoc labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caesar Cipher Conversion project using javascript
2 participants