Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-2779 rename round to era #11

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Conversation

nahuseyoum
Copy link
Contributor

This PR is a pure rename of round to era with no additional functionality. This rename is useful because it matches the terminology used by substrate's staking pallet and our offchain products.

fluorostani
fluorostani previously approved these changes Oct 21, 2022
thadouk
thadouk previously approved these changes Oct 21, 2022
Copy link
Contributor

@thadouk thadouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this Era match the Substrate Era in terms of time?
Meaning is 1 Era in the staking pallet starts and end in an era of the framework & the sessions?
If not this could create some confusion.

@nahuseyoum
Copy link
Contributor Author

Does this Era match the Substrate Era in terms of time? Meaning is 1 Era in the staking pallet starts and end in an era of the framework & the sessions? If not this could create some confusion.

We don't use substrate's staking pallet on our parachain so there shouldn't be any overlap there. In terms of defining how long an era is, its configurable.

Nahu Seyoum added 2 commits October 21, 2022 11:10
…etwork-Services/avn-parachain into nahu-sys2779-renameRoundToEra
Base automatically changed from nahu-sys2779-removeUnusedCode2 to main October 21, 2022 10:19
@nahuseyoum nahuseyoum dismissed stale reviews from thadouk and fluorostani via 08013e9 October 21, 2022 10:19
@nahuseyoum nahuseyoum merged commit dd50026 into main Oct 21, 2022
@nahuseyoum nahuseyoum deleted the nahu-sys2779-renameRoundToEra branch October 21, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants