-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYS-3556 Convert ethereum-transactions pallet to use BoundedVec #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-cholakov
approved these changes
Aug 14, 2023
thadouk
requested changes
Aug 16, 2023
alexpArtos
approved these changes
Aug 17, 2023
fluorostani
changed the title
SYS-3556 Convert ethereum-transactions pallet to use BoundedVec
WIP - SYS-3556 Convert ethereum-transactions pallet to use BoundedVec
Aug 18, 2023
alexpArtos
approved these changes
Aug 18, 2023
alexpArtos
approved these changes
Aug 22, 2023
ivan-cholakov
force-pushed
the
glyn_eth_tx
branch
from
August 23, 2023 09:53
7871538
to
1d4c64c
Compare
alexpArtos
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I want to approve this PR. Just want to be sure if the necessary migration fits in one block or we need to use the technique to restart it periodically
ivan-cholakov
force-pushed
the
glyn_eth_tx
branch
from
September 4, 2023 14:52
f920214
to
8b09573
Compare
fluorostani
changed the title
WIP - SYS-3556 Convert ethereum-transactions pallet to use BoundedVec
SYS-3556 Convert ethereum-transactions pallet to use BoundedVec
Sep 5, 2023
ivan-cholakov
force-pushed
the
glyn_eth_tx
branch
from
September 5, 2023 15:06
547c59f
to
68ded83
Compare
thadouk
approved these changes
Sep 5, 2023
ivan-cholakov
force-pushed
the
glyn_eth_tx
branch
2 times, most recently
from
September 5, 2023 16:46
87489da
to
37e1a56
Compare
ivan-cholakov
force-pushed
the
glyn_eth_tx
branch
2 times, most recently
from
September 5, 2023 16:47
37e1a56
to
f54c3f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
converted ethereum-transactions-pallet to use BoundedVec for the number of its validators
Type of change/Merge
🚨What type of change is this PR?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.