Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-3556 Convert ethereum-transactions pallet to use BoundedVec #215

Merged
merged 11 commits into from
Sep 5, 2023

Conversation

fluorostani
Copy link
Contributor

@fluorostani fluorostani commented Aug 14, 2023

Proposed changes

converted ethereum-transactions-pallet to use BoundedVec for the number of its validators

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

@fluorostani fluorostani changed the title SYS-3556 Convert ethereum-transactions pallet to use BoundedVec WIP - SYS-3556 Convert ethereum-transactions pallet to use BoundedVec Aug 18, 2023
Copy link
Contributor

@alexpArtos alexpArtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I want to approve this PR. Just want to be sure if the necessary migration fits in one block or we need to use the technique to restart it periodically

@fluorostani fluorostani changed the title WIP - SYS-3556 Convert ethereum-transactions pallet to use BoundedVec SYS-3556 Convert ethereum-transactions pallet to use BoundedVec Sep 5, 2023
@ivan-cholakov ivan-cholakov force-pushed the glyn_eth_tx branch 2 times, most recently from 87489da to 37e1a56 Compare September 5, 2023 16:46
@ivan-cholakov ivan-cholakov force-pushed the glyn_eth_tx branch 2 times, most recently from 37e1a56 to f54c3f2 Compare September 5, 2023 16:47
@ivan-cholakov ivan-cholakov merged commit 2769304 into main Sep 5, 2023
5 checks passed
@ivan-cholakov ivan-cholakov deleted the glyn_eth_tx branch September 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants