Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-3555 convert parachain staking to bounded vec storage items (#198) #221

Conversation

thadouk
Copy link
Contributor

@thadouk thadouk commented Aug 17, 2023

Proposed changes

Reinstates commit 74ed078 and the work done on #198
this PR introduces bounded data structures to parachain-staking
Related Jira items:

  • SYS-3338

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

@thadouk thadouk force-pushed the thadouk-SYS-3555-reinstate-parachain-staking-convertion-to-use-boundedvec branch from d7c8abc to 8d6f560 Compare August 25, 2023 15:57
@thadouk thadouk merged commit 2aba9d2 into main Aug 25, 2023
5 of 8 checks passed
@thadouk thadouk deleted the thadouk-SYS-3555-reinstate-parachain-staking-convertion-to-use-boundedvec branch August 25, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants