Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-3705 Allow try-runtime support #273

Merged
merged 7 commits into from
Oct 18, 2023
Merged

SYS-3705 Allow try-runtime support #273

merged 7 commits into from
Oct 18, 2023

Conversation

nahuseyoum
Copy link
Contributor

Proposed changes

This PR allows the node to be compiled using the try-runtime feature so we can do dry runs of storage migrations using production chain state.

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

image

image

@ivan-cholakov
Copy link
Contributor

I think you are including the changes from the removal of avt-finality-tracker

@nahuseyoum
Copy link
Contributor Author

I think you are including the changes from the removal of avt-finality-tracker

Yes, I didn't think there would be much point to update cargo.toml of a pallet we are removing :). This PR will go in after the removal.

@nahuseyoum nahuseyoum merged commit 371ae13 into main Oct 18, 2023
5 checks passed
@nahuseyoum nahuseyoum deleted the nahu-tryRuntime branch October 18, 2023 22:22
thadouk pushed a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants