SYS-3773 Bug fix to handle bad transaction hashes and various improvements #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahuseyoum
requested review from
alexpArtos,
fluorostani and
thadouk
as code owners
nahuseyoum
changed the title
ivan-cholakov
approved these changes
Dec 18, 2023
fluorostani
approved these changes
Dec 18, 2023
alexpArtos
reviewed
Jan 3, 2024
| assert_eq!((next_tx_id as u64).encode(), new_transaction_id_bytes); | ||
| assert_eq!(expiry, 7200); |
There was a problem hiding this comment.
Why do we do this assert here? This forces the expiry to be a fixed constant, and in that case, why does it exist as a storage item?
There was a problem hiding this comment.
This is on state migration only
| @@ -105,6 +105,12 @@ pub fn set_up_active_tx<T: Config>(req: SendRequestData) -> Result<(), Error<T>> | |||
| } | |||
|
|
|||
| pub fn replay_send_request<T: Config>(mut tx: ActiveTransactionData<T>) -> Result<(), Error<T>> { | |||
There was a problem hiding this comment.
I see this is called from finalize_state, and that in turn is called from add_corroboration. But I don't see any limit to how many times we retry, or why we want to retry if we know the transaction has already failed.
There was a problem hiding this comment.
If the sender is a malicious author, we retry until we find an honest author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a bug where ethereum events gets stuck processing invalid transaction hashes. It also adds a new event to signal retries and automatically sets expiry period during a forkless upgrade.
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Further comments