SYS-3801 Adds state migration for summary pallet #343
Conversation
nahuseyoum
requested review from
alexpArtos,
fluorostani and
thadouk
as code owners
| @@ -16,7 +16,7 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
| hex = { version = "0.4.3", default-features = false, features = ["alloc"] } | |||
| hex-literal = { version = "0.3.4", default-features = false } | |||
| scale-info = { version = "2.0", default-features = false, features = ["derive"] } | |||
|
|
|||
| log = { version = "0.4.17", default-features = false } | |||
There was a problem hiding this comment.
I don't think we need to, its only used in a migration file.
| let current = Pallet::<T>::current_storage_version(); | ||
| let onchain = Pallet::<T>::on_chain_storage_version(); | ||
|
|
||
| if onchain == 2 && current == 3 { |
There was a problem hiding this comment.
its not shown on the PR, what is the storage version atm for parachain staking?
There was a problem hiding this comment.
This is the same guard as the one used in the actual code that runs it. On Mainnet onchain is 2.
| new_transaction_id, | ||
| ); | ||
|
|
||
| counter += 1; |
There was a problem hiding this comment.
consider using saturated add
There was a problem hiding this comment.
We only have a few hundred items on mainnet and this will be removed soon.
| let current = pallet_eth_bridge::Pallet::<Runtime>::current_storage_version(); | ||
|
|
||
| if current == 1 { | ||
| let next_tx_id: u32 = pallet_eth_bridge::Pallet::<Runtime>::get_next_tx_id(); | ||
| let expiry = <pallet_eth_bridge::Pallet<Runtime> as pallet_eth_bridge::Store>::EthTxLifetimeSecs::get(); | ||
| assert_eq!((next_tx_id as u64).encode(), new_transaction_id_bytes); | ||
| assert_eq!(expiry, 7200); | ||
| } |
There was a problem hiding this comment.
can we discuss this offline? Not that familiar with the pre/post upgrade of the try-runtime.
There was a problem hiding this comment.
Sure, more details here: https://github.com/AventusProtocolFoundation/avn-parachain#storage-migration-tests
Proposed changes
This PR adds a state migration to the summary pallet to avoid corrupting the roots data storage
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Further comments