Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-3866 Update summary benchmarks #347

Merged
merged 8 commits into from
Feb 2, 2024
Merged

SYS-3866 Update summary benchmarks #347

merged 8 commits into from
Feb 2, 2024

Conversation

nahuseyoum
Copy link
Contributor

Proposed changes

This PR updates the summary benchmark to take into account the max offenders list.

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

Copy link
Contributor

@fluorostani fluorostani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be an idea to combine "MAX_NUMBER_OF_VALIDATORS_ACCOUNTS" and "MAX_VALIDATOR_ACCOUNT_IDS" into a single "MAX_VALIDATOR_ACCOUNTS"?

… `MAX_VALIDATOR_ACCOUNT_IDS` into `MAX_VALIDATOR_ACCOUNTS`
@nahuseyoum
Copy link
Contributor Author

Would it be an idea to combine "MAX_NUMBER_OF_VALIDATORS_ACCOUNTS" and "MAX_VALIDATOR_ACCOUNT_IDS" into a single "MAX_VALIDATOR_ACCOUNTS"?

good idea, I have centralised them.

Base automatically changed from nahu-sys3867-bench1 to main February 2, 2024 10:46
@nahuseyoum nahuseyoum merged commit ed2c29c into main Feb 2, 2024
5 checks passed
@nahuseyoum nahuseyoum deleted the nahu-sys3866-bench2 branch February 2, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants