Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-3828: updated pallet eth-bridge #354

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

ivan-cholakov
Copy link
Contributor

Updated eth-bridge pallet

@ivan-cholakov ivan-cholakov changed the base branch from main to SYS-3828-upgrade-substrate-version February 15, 2024 17:36
"codec/std",
"sp-std/std",
"sp-core/std",
"frame-support/std",
"sp-application-crypto/std",
"sp-io/std",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation issue

hex-literal = { version = "0.4.1", default-features = false }
rand = { version = "0.8.5", default-features = false }
scale-info = { version = "2.5.0", default-features = false, features = ["derive"] }
sp-std = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v1.0.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run a formatter to change the order of the imports?

@@ -229,15 +227,15 @@ pub mod pallet {
pub next_tx_id: EthereumId,
}

#[cfg(feature = "std")]
// #[cfg(feature = "std")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

@ivan-cholakov ivan-cholakov merged commit 6ee1781 into SYS-3828-upgrade-substrate-version Feb 20, 2024
@ivan-cholakov ivan-cholakov deleted the SYS-3828-eth-bridge branch February 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants