SYS-3941 add log lowered claimed event #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBrozhko34
changed the title
MBrozhko34
requested review from
nahuseyoum,
alexpArtos and
fluorostani
as code owners
MBrozhko34
force-pushed
the
SYS-3941-add-LogLoweredClaimed-event
branch
from
213bd66
to
b8024f3
Compare
alexpArtos
approved these changes
Apr 4, 2024
Comment on lines
+992
to
+999
| return match &event.event_data { | ||
| EventData::LogLifted(d) => return Self::process_lift(event, d), | ||
| EventData::LogAvtGrowthLifted(d) => return Self::process_avt_growth_lift(event, d), | ||
| EventData::LogLowerClaimed(d) => return Self::process_lower_claim(event, d), | ||
|
|
||
| // Event handled or it is not for us, in which case ignore it. | ||
| _ => Ok(()), | ||
| } |
ivan-cholakov
approved these changes
Apr 5, 2024
MBrozhko34
force-pushed
the
SYS-3941-add-LogLoweredClaimed-event
branch
from
04413f9
to
0322ccb
Compare
MBrozhko34
force-pushed
the
SYS-3941-add-LogLoweredClaimed-event
branch
from
0322ccb
to
8eceeaf
Compare
alexpArtos
approved these changes
Apr 5, 2024
|
|
||
| assert_ok!(TokenManager::on_event_processed(&mock_event)); | ||
|
|
||
| assert!(System::events().iter().any(|a| a.event == |
There was a problem hiding this comment.
might as well add that the lower is not present in the storage item ReadyToClaim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added LogLoweredClaimed event to primitives, add event handling and update token manager to consume the event.
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.