Introduces initial range consesnus mechanism #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range.
thadouk
requested review from
nahuseyoum,
alexpArtos and
fluorostani
as code owners
ivan-cholakov
approved these changes
Apr 26, 2024
nahuseyoum
reviewed
Apr 30, 2024
pallets/eth-bridge/src/lib.rs
Outdated
| latest_seen_block, | ||
| ); | ||
| if let Some(events_partition) = | ||
| events_helpers::discovered_eth_events_partition_factory(nominated_range, Vec::new()) |
There was a problem hiding this comment.
Why are we calling this function with an empty array?
There was a problem hiding this comment.
its a factory method that produces partitions given an input of events. In the case of the initial range consensus we are interested in producing a partition with no events and the nominated_range
thadouk
changed the title
thadouk
deleted the
thadouk-introduce-first-range-consensus-mechanism-extrinsic
branch
thadouk
added a commit
that referenced
this pull request
May 3, 2024
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range. Jira ticket: - SYS-3930
thadouk
added a commit
that referenced
this pull request
May 23, 2024
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range. Jira ticket: - SYS-3930
thadouk
added a commit
that referenced
this pull request
Jun 5, 2024
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range. Jira ticket: - SYS-3930
thadouk
added a commit
that referenced
this pull request
Jun 26, 2024
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range. Jira ticket: - SYS-3930
thadouk
added a commit
that referenced
this pull request
Jun 26, 2024
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used. This allows to simplify the voting logic for active ranges, eliminating the special case of the first range. Jira ticket: - SYS-3930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a new endpoint that allows the chain to reach consenus over the initial ethereum range to be used.
This allows to simplify the voting logic for active ranges, eliminating the special case of the first range.