Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-3955 Improve length comparison part 2 #394

Merged
merged 2 commits into from
May 2, 2024

Conversation

nahuseyoum
Copy link
Contributor

@nahuseyoum nahuseyoum commented Apr 30, 2024

Proposed changes

This PR adds some minor improvements when doing checks to determine if a vector is empty or not.

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

@@ -169,7 +169,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("avn-test-parachain"),
impl_name: create_runtime_str!("avn-test-parachain"),
authoring_version: 1,
spec_version: 62,
spec_version: 63,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely this is an impl version increase

@nahuseyoum nahuseyoum merged commit f80a9ef into main May 2, 2024
5 of 8 checks passed
@nahuseyoum nahuseyoum deleted the nahu-SYS-3955-Improve-length-comparison-part2 branch May 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants