fix: refactored getting the authors to verify current node's author #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-cholakov
requested review from
nahuseyoum,
fluorostani and
thadouk
as code owners
nahuseyoum
approved these changes
May 13, 2024
Base automatically changed from
thadouk-integrate-initial-range-to-client
to
feat/SYS-3560-add-event-listener
May 14, 2024 07:06
ivan-cholakov
force-pushed
the
NO_JIRA-fix-querying-validators
branch
from
5af2a84
to
4aa20b1
Compare
thadouk
reviewed
May 14, 2024
| @@ -314,6 +314,21 @@ where | |||
| Err(AppError::GenericError("Failed to initialize web3 after multiple attempts.".to_string())) | |||
| } | |||
|
|
|||
| fn find_author_account_id<T>( | |||
| author_public_keys: Result<Vec<[u8; 32]>,T>, | |||
There was a problem hiding this comment.
Why do we pass a result here? can we not pass the key and handle/unwrap the result when it is returned?
| @@ -177,7 +187,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("avn-parachain"), | |||
| impl_name: create_runtime_str!("avn-parachain"), | |||
| authoring_version: 1, | |||
| spec_version: 64, | |||
| spec_version: 60, | |||
thadouk
pushed a commit
that referenced
this pull request
May 23, 2024
thadouk
pushed a commit
that referenced
this pull request
Jun 5, 2024
thadouk
pushed a commit
that referenced
this pull request
Jun 26, 2024
thadouk
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
getting the author for current node, as it requiresexternalities, we are exposing thevalidatorsstorage item to iterate through to find the correct keystore public key