Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration cleanup and tidy up #399

Merged
merged 7 commits into from
May 15, 2024
Merged

Migration cleanup and tidy up #399

merged 7 commits into from
May 15, 2024

Conversation

thadouk
Copy link
Contributor

@thadouk thadouk commented May 15, 2024

Proposed changes

This PR cleanups the migrations and fixes some other minor issues:

  • Removes migrations from summary, validators manager and staking pallets and their wire up with runtime. These migrations have been completed a long time ago on all active chains. Its good practice to remove from time to time to reduce the size of the codebase and upgrade checks performed. All migrations set the right storage item on the genesis build block, so new chains are skipping the migration.
  • updates grade configuration for sepolia.

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

Copy link
Contributor

@nahuseyoum nahuseyoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thadouk thadouk force-pushed the thadouk-migration-cleanup branch from 9be2dfa to 674bdd2 Compare May 15, 2024 13:06
@thadouk thadouk force-pushed the thadouk-migration-cleanup branch from c48e499 to 2ef2e97 Compare May 15, 2024 13:11
@thadouk thadouk merged commit b1ac34e into main May 15, 2024
8 of 10 checks passed
@thadouk thadouk deleted the thadouk-migration-cleanup branch May 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants