Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-4051 Update weights for eth events #401

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

nahuseyoum
Copy link
Contributor

@nahuseyoum nahuseyoum commented May 15, 2024

Proposed changes

This PR updates the weight calculation in Eth events pallet to use realistic values and decouple the max storage bound from the constants used in Weight calculation.

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

thadouk and others added 2 commits May 15, 2024 14:41
Updates tests and code accordingly to use storage items as needed
without the Store trait dependency
Base automatically changed from thadouk-remove-store-references to main May 15, 2024 17:19
@@ -50,7 +50,6 @@ pub mod pallet {
}

#[pallet::pallet]
#[pallet::generate_store(pub (super) trait Store)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a rebase is needed. I think Thanos removed this and it is already merged to main

@nahuseyoum nahuseyoum merged commit 9c68887 into main May 16, 2024
5 checks passed
@nahuseyoum nahuseyoum deleted the nahu-sys4051-batchFix branch May 16, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants