Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container image generation #407

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: container image generation #407

merged 1 commit into from
May 29, 2024

Conversation

thadouk
Copy link
Contributor

@thadouk thadouk commented May 29, 2024

Fixes an issues with the container image generation, where the wrong path was used as the default execution path, leading to some errors when the node was trying to access the /data storage, resulting to this error:

Os { code: 13, kind: PermissionDenied, message: \\"Permission denied\\"}

Proposed changes

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

Fixes an issues with the container image generation, where the wrong
path was used as the default execution path, leading to some errors when
the node was trying to access the /data storage, resulting to this
error:

`Os { code: 13, kind: PermissionDenied, message: \\"Permission denied\\"}`
@thadouk thadouk merged commit 04c220b into main May 29, 2024
5 checks passed
@thadouk thadouk deleted the fix-dockerfiles-permitions branch May 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants