Sys 4010 make autogrowth mechanism configurable #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelffrancoAV
requested review from
nahuseyoum,
fluorostani and
thadouk
as code owners
ivan-cholakov
approved these changes
Jun 19, 2024
nahuseyoum
reviewed
Jun 19, 2024
There was a problem hiding this comment.
The way its setup now, we need to have a storage migration script to set this value to true so it doesn't break for Aventus so we can either :
- include a migration script or
- invert the logic and use
growth_disabled. This way, by default, Growth will be triggered and if a client wants to disable it, they can using the SUDO extrinsic.
| @@ -245,6 +245,8 @@ pub mod pallet { | |||
| type AccountToBytesConvert: pallet_avn::AccountToBytesConverter<Self::AccountId>; | |||
|
|
|||
| type BridgeInterface: pallet_avn::BridgeInterface; | |||
|
|
|||
| type GrowthEnabled: Get<bool>; | |||
There was a problem hiding this comment.
if we are setting it in storage, I guess we can remove the config trait?
nahuseyoum
approved these changes
Jun 26, 2024
| @@ -245,6 +245,8 @@ pub mod pallet { | |||
| type AccountToBytesConvert: pallet_avn::AccountToBytesConverter<Self::AccountId>; | |||
|
|
|||
| type BridgeInterface: pallet_avn::BridgeInterface; | |||
|
|
|||
| type GrowthEnabled: Get<bool>; | |||
There was a problem hiding this comment.
Suggested change
| type GrowthEnabled: Get<bool>; | |
| #[pallet::constant] | |
| type GrowthEnabled: Get<bool>; |
pallets/parachain-staking/src/lib.rs
Outdated
| @@ -687,6 +689,7 @@ pub mod pallet { | |||
| pub delay: EraIndex, | |||
| pub min_collator_stake: BalanceOf<T>, | |||
| pub min_total_nominator_stake: BalanceOf<T>, | |||
| pub growth_enabled: bool, | |||
pallets/parachain-staking/src/lib.rs
Outdated
| @@ -697,6 +700,7 @@ pub mod pallet { | |||
| delay: Default::default(), | |||
| min_collator_stake: Default::default(), | |||
| min_total_nominator_stake: Default::default(), | |||
| growth_enabled: T::GrowthEnabled::get(), | |||
| @@ -566,6 +583,7 @@ impl ExtBuilder { | |||
| delay: 2, | |||
| min_collator_stake: self.min_collator_stake, | |||
| min_total_nominator_stake: self.min_total_nominator_stake, | |||
| growth_enabled: true, | |||
| } | ||
|
|
||
| #[test] | ||
| fn growth_info_is_not_updated() { |
pallets/token-manager/src/mock.rs
Outdated
| @@ -439,6 +441,7 @@ impl ExtBuilder { | |||
| delay: 2, | |||
| min_collator_stake: 10, | |||
| min_total_nominator_stake: 5, | |||
| growth_enabled: true, | |||
| @@ -502,6 +504,7 @@ impl ExtBuilder { | |||
| delay: 2, | |||
| min_collator_stake: 10, | |||
| min_total_nominator_stake: 5, | |||
| growth_enabled: true, | |||
micaelffrancoAV
deleted the
SYS-4010_Make_autogrowth_mechanism_configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Further comments