Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-4125 Fix try runtime compilation error #423

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

nahuseyoum
Copy link
Contributor

@nahuseyoum nahuseyoum commented Jun 21, 2024

Proposed changes

This PR fixes the compilation error thrown when compiling the node with the try-runtime feature.

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

  • Release
    • Increase versions
    • Baseline tests passed
    • Release type:
      • Major release
      • Minor release
      • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • You describe the purpose of the PR, e.g.:
    • What does it do?
    • Highlight what important points reviewers should know about;
    • Indicates if there is something left for follow-up PRs.
  • Documentation updated
  • Business logic tested successfully
  • Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

@nahuseyoum nahuseyoum changed the title Nahu fix token manager try runtime SYS-??? Fix try runtime compilation error Jun 21, 2024
@nahuseyoum nahuseyoum changed the title SYS-??? Fix try runtime compilation error SYS-4125 Fix try runtime compilation error Jun 21, 2024
@nahuseyoum nahuseyoum merged commit 618c462 into main Jun 24, 2024
5 checks passed
@nahuseyoum nahuseyoum deleted the nahu-fix-tokenManager-tryRuntime branch June 24, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants