SYS-4144: Adding filter to ethereum-events #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelffrancoAV
requested review from
nahuseyoum,
fluorostani and
thadouk
as code owners
thadouk
reviewed
Jul 11, 2024
pallets/ethereum-events/src/lib.rs
Outdated
| @@ -712,6 +715,9 @@ pub mod pallet { | |||
| let account_id = ensure_signed(origin)?; | |||
| ensure!(&tx_hash != &H256::zero(), Error::<T>::MalformedHash); | |||
|
|
|||
| let filter = T::EthereumEventsFilter::get_filter(); | |||
| ensure!(!filter.contains(&event_type), Error::<T>::ErrorAddingEthereumLog); | |||
|
|
|||
| // TODO [TYPE: weightInfo][PRI: medium]: Return accurate weight | |||
| return Self::add_event(event_type, tx_hash, account_id) | |||
There was a problem hiding this comment.
I think the check should be done in this function to ensure all entry points for events are checked:
- add_validator_log
- add_lift_log
- add_ethereum_log
thadouk
approved these changes
Jul 11, 2024
nahuseyoum
approved these changes
Jul 11, 2024
micaelffrancoAV
deleted the
SYS-4144_make_events_accepted_by_ethereum-events_configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add filter to ethereum-events.
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Further comments