SYS-4116: Enable lift on eth-bridge

[micaelffrancoAV]

Proposed changes

Type of change/Merge

🚨What type of change is this PR?

Put an x in the boxes that apply

• Release
  • Increase versions
  • Baseline tests passed
  • Release type:
    • Major release
    • Minor release
    • Patch release

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

• You describe the purpose of the PR, e.g.:
  • What does it do?
  • Highlight what important points reviewers should know about;
  • Indicates if there is something left for follow-up PRs.
• Documentation updated
• Business logic tested successfully
• Verify First, Write Last: In Substrate development, it is important that you always ensure preconditions are met and return errors at the beginning. After these checks have completed, then you may begin the function's computation.

Further comments

[nahuseyoum]

The changes on this PR are fine 😃 in that they enable lifting to be processed via ethBridge but shouldn't we also update the block explorer and processors to treat ethbridge.eventRejected as Failed? At the moment only ethereumEvents.eventRejected is considered. Tagging @thadouk @ivan-cholakov

[thadouk]

The changes on this PR are fine 😃 in that they enable lifting to be processed via ethBridge but shouldn't we also update the block explorer and processors to treat ethbridge.eventRejected as Failed? At the moment only ethereumEvents.eventRejected is considered. Tagging @thadouk @ivan-cholakov

Yes, anything depending on the old interface should be updated to the new. I wouldn't block this, as it can be promoted in internal chains and enable testing.