Include only existent files (no dirs) in config files discovery

[jneira]

• To fix Implicit cradle failure: /home/user/.cabal: openFile: inappropriate type (is a directory) haskell/haskell-language-server#417

[georgefst]

I'm not sure this is quite correct? Since that function is also used by e.g. stackWorkDir, which actually expects a directory.

[jneira]

@georgefst ugh, thanks for noting that, I saw the unused binding and I assumed with no further thinking that it should be used but we forgot to do it.
And the name of the function did not help too.

[jneira]

Ok i think this version could be correct. It contains some duplication but i think names are clear and the diff is not big.
I've tested it with some projects and it worked fine. A test suite could be invaluable.

[jneira]

@Avi-D-coder dont want to be pushy but could you take a quick look to fix the bug asap?

[Avi-D-coder]

This looks correct.
I have not yet tested it.
If you think it's ready feel free to merge and I'll cut a release.

[Avi-D-coder]

I'm not exactly clear about how to reproduce haskell/haskell-language-server#417, is it a standalone file or a project? What does tree look like?

[jneira]

i've reproduced it running hls in console mode in a directory with only a standalone hs and create in its parent directory an empty directory named .cabal

[Avi-D-coder]

Thanks. I have no concerns. I used hls with this patch and everything seems to work. Is it ready to merge?

[jneira]

Yeah, it is ready. Thanks for testing it.