merge from master #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, we never update the compiler options stored for scripts. This means that as you add #r or #load the compilation options aren't updated. This PR updates the options in the semantic analysis phase. We can't update them on every request for options because it is too expensive. This fixes some aspects of #1808 but the underlying problem of not reacting to file update events in dependencies is not fixed.
…e” branch, but not being reset. Therefor we get too specific error message:ElseBranch should only work on the return type (#1827)
Fix printing of "null" values
* case names from FCS * additional case names
… value and works for F# to F# calls (#1812) * First rough try. * Write DefaultParameterValue to Constant table. * Rename GenDefaultParameterValue and make local. * Optional+DefaultParamValue args F# to F# works. * Add first set of tests. * Add more tests. * Extract const to fieldinit code to active pattern. * Add tests for Nullable optional parameters. * Add one more test. * Add compiler error to avoid unverifiable code. * Add proper comment. * Spaces. * Allow callling F# methods only marked with Optional. The behavior here matches that of C# as far as I can tell, but it seems unspecified anywhere. I could not find a reference to it in the C# 5.0 spec or C# 6.0 draft spec. In particular the System.Reflection.Missing for obj is interesting. * Make error into a warning, improve text. * Clean up test names, more conventional. * Add test that calls F# from F# in other assembly.
* fix glyph * fix glyph * fix glyph
add notes on configuring nuget.exe to use proxy
* fix tests * FIx tutorial
* fix tests * fix-1898 * better diagnostics in env.lst
This fixes a large chunk of #1808. I've tested it by hand. The build still doesn't react to files coming/going in DependencyFiles. I'll adjust the description in #1808 to make the cases distinct. Basically F# has an analysis engine which tells the UI when to do "foreground" rechecks of files because the checking state has changed. This reacts to those events. See https://fsharp.github.io/FSharp.Compiler.Service/queue.html for some info. When the UI gets the focus on a document, it should also notify the F# engine to start checking that document * fix tests * Fix bridge between backgronud builders * fix test
) * Emit special warning when = is used and user might want to use <- * Don't warn if there is no setter * Move IsPropertyGetter and IsPropertySetter to tast.fs * Show property name in error message * Use IsPropertyGetterMethod/IsPropertySetterMethod in Symbols.fs * Only warn on last expression in a sequence - fixes #326 * Extract ReportImplicitlyIgnoredBoolExpression as separate function * Detect "in" expressions
* use shared MEF components instead of static fields * revert back stateless static methods that were used in tests * remove Document from the signature
do not trigger autocomple after double dot
* Update Tests.LanguageService.Completion.fs
* Hook F# Interactive menu commands into language service Rudimentary implementation * Refactor * Refactor again for better robustness
…c do not run to completion (#1926) * do not throw exception if LanguageDebugInfoService.GetDataTipInfoAsync do not run to completion * CommonRoslynHelpers.StartAsyncAsTask catches exceptions and transform them to Assert.Exception instead of reraising
* Trace errors in from fsdiff * Port diff code * Remove diff.exe and use it directly in F# TestSuite
…compute argument index (#1895) * Show 'no documentation' as QuickInfo workaround when no XML doc comments are defined * Don't add newline if there aren't parameter docs * Don't ask BuildMethodOverloadTipText to also handle parameters * Show all parameters when invoking signature helper * Account for edge case when computing argument index. * Adjust tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.