Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay mask bug #255

Closed
realfinder opened this issue Jan 20, 2022 · 6 comments
Closed

overlay mask bug #255

realfinder opened this issue Jan 20, 2022 · 6 comments

Comments

@realfinder
Copy link

as it said here https://forum.doom9.org/showthread.php?t=183710

@pinterf
Copy link

pinterf commented Jan 21, 2022

@pinterf
Copy link

pinterf commented Jan 21, 2022

In my opinion this is not a bug, integer implementation may need exact explanation in documentation.
Or one would use 32 bit float format instead.

@realfinder
Copy link
Author

thanks, so vs Overlay is slower, right?

@pinterf
Copy link

pinterf commented Jan 27, 2022

Eh, this turned into a one-week work, including reconstruction of the old ugly codebase and rewriting the all the stuff and added AVX2 as well.
Now I have benchmarks as well, it seems that the accurate new 8 bit basic (mask=yes, opacity=1.0) Overlay is slower (480fps vs 550fps - AVX2, 305 vs 550fps for pre-AVX2 processors)
But all the other cases - when opacity is <1.0 or bit depth>=10 we got a significant speed boost.

@pinterf
Copy link

pinterf commented Feb 8, 2022

Maskless blend is broken

@pinterf
Copy link

pinterf commented Feb 8, 2022

Maskless blend regression is fixed via 6884b1c

@pinterf pinterf closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants