Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Controller build and initialization modules (and updated existing) #10

Merged
merged 6 commits into from
Jul 26, 2018
Merged

Added Controller build and initialization modules (and updated existing) #10

merged 6 commits into from
Jul 26, 2018

Conversation

mike-r-mclaughlin
Copy link

aviatrix-controller-iam-roles - updated to latest version of policies
aviatrix-controller-build - updates to use metered AMI by default and added map for all regions
aviatrix-controller-build-cft - new module to build a controller using the CFT
aviatrix-controller-initialize - new module to initialize the Controller


data "aws_region" "current" {}

locals {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use http Data Source to query the ami ID from https://s3-us-west-2.amazonaws.com/aviatrix-download/AMI_ID/ami_id.json? This would help avoid duplication

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this idea. But, I can't figure out how to do this without the new jsondecode function from Terraform. We could write a function and put it here:
https://github.com/hashicorp/terraform/blob/master/config/interpolate_funcs.go (as suggested by this thread.
Let me know if I've missed another way of doing this.

Copy link
Collaborator

@arvindsree arvindsree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

{
"Effect": "Allow",
"Action": [
"elasticloadbalancing:RegisterInstancesWithLoadBalancer",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the IAM policies. If we could query the latest IAM policy that would be ideal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are those policies in a file somewhere? if they are in their own file then the http data source will work. if we need to parse the file, it seems like it won't work (unless I've missed something).

@sxw97g sxw97g merged commit 008ca86 into AviatrixSystems:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants