Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch sharedarray version due to numpy updating #850

Merged
merged 4 commits into from
Jun 29, 2024
Merged

Patch sharedarray version due to numpy updating #850

merged 4 commits into from
Jun 29, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Similar to https://github.com/XENONnT/cutax/pull/439, following XENONnT/base_environment#1718.

Since numpy updated to 2.0.0 and sharedaray does not follow the updates timely, we see error like https://github.com/AxFoundation/strax/actions/runs/9726479771/job/26844965537?pr=849. To fix it, we assign a dedicated sharedarray version. It required numpy<2.0.0.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

coverage: 90.587% (-0.06%) from 90.645%
when pulling 7676b0f on fix_numpy
into d0cbc1b on master.

@coveralls
Copy link

Coverage Status

coverage: 90.543% (-0.1%) from 90.645%
when pulling d1492a1 on fix_numpy
into d0cbc1b on master.

@coveralls
Copy link

Coverage Status

coverage: 90.587% (-0.06%) from 90.645%
when pulling d1492a1 on fix_numpy
into d0cbc1b on master.

@dachengx dachengx marked this pull request as ready for review June 29, 2024 20:44
@dachengx dachengx merged commit d92e64b into master Jun 29, 2024
8 of 9 checks passed
@dachengx dachengx deleted the fix_numpy branch June 29, 2024 20:45
@coveralls
Copy link

Coverage Status

coverage: 90.543% (-0.1%) from 90.645%
when pulling d1492a1 on fix_numpy
into d0cbc1b on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants