Also add new_with_buffer_capacity

[ryoqun]

we need to adjust the internal BufWriter capacity via its construction for best performance of super write intensive tasks: https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.with_capacity

so, add another method, not to break compatibility.

[kevinhoffman]

@ryoqun - thanks for the PR, looks good. Could you run cargo fmt and resubmit so it will pass the test suite? Also, perhaps modify the tests build_context function to accept a new Option(usize) capacity arg and call new or new_with_capacity as appropriate, and then add a new test to test that when a large capacity is specified things work as designed?

[kevinhoffman]

@ryoqun - it also looks like clippy is failing now since chrono::TimeZone::ymd is deprecated it wants us to use with_ymd_and_hms -- chrono dependency could be explicitly advanced to require 0.4.23 and use the new function, or locked to 0.4.22 to avoid the deprecated function (might cause issues later). I'd be happy to address this first, or if you wanted to address that change with another commit in this PR too that is fine.

[ryoqun]

@kevinhoffman thanks for reply!

Could you run cargo fmt and resubmit so it will pass the test suite?

done

Also, perhaps modify the tests build_context function to accept a new Option(usize) capacity arg and call new or new_with_capacity as appropriate, and then add a new test to test that when a large capacity is specified things work as designed?

yeah done (mostly at 33bb6c6)

it also looks like clippy is failing now since chrono::TimeZone::ymd is deprecated it wants us to use with_ymd_and_hms -- chrono dependency could be explicitly advanced to require 0.4.23 and use the new function, or locked to 0.4.22 to avoid the deprecated function (might cause issues later). I'd be happy to address this first, or if you wanted to address that change with another commit in this PR too that is fine.

after some research and thought, i decided to bump chrono version. it seems that this is what other crates are doing according to https://crates.io/crates/chrono/reverse_dependencies.

[kevinhoffman]

@ryoqun - wonderful. and thank you for fixing the clippy/chrono items too.