Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement statistics for weighted uniform dist #55

Merged
merged 2 commits into from
May 30, 2023

Conversation

samnaughtonb
Copy link
Contributor

Hi @Axect,

Submitting a PR to add stats for the 1D weighted uniform distribution. I couldn't think of a better way of computing the variance without access to the unconditional mean.

Let me know what you think.

Sam

@Axect
Copy link
Owner

Axect commented May 30, 2023

Hello @samnaughtonb,

Thank you for your interest and valuable contribution. I'm genuinely impressed by your initiative to enhance the weighted uniform distribution, particularly considering there isn't any existing documentation to guide you.

After reviewing your code, I find your approach to computing the variance, especially without access to the unconditional mean, quite ingenious.

I appreciate your attention to detail and effort in enhancing this feature. I have no reservations in accepting your pull request. It will be merged shortly, and an updated version with your contributions will be published soon. Please continue to share your insights and improvements as they are truly appreciated.

Once again, thank you for your dedicated effort and contribution to this project.

Best regards,
Axect

@Axect Axect merged commit 383a442 into Axect:dev May 30, 2023
@Axect Axect requested review from Axect and removed request for Axect May 30, 2023 06:49
@Axect Axect added the enhancement New feature or request label May 30, 2023
@samnaughtonb samnaughtonb deleted the feature/weighted-uniform-moments branch May 30, 2023 19:50
@samnaughtonb
Copy link
Contributor Author

Your feedback is greatly appreciated! Looking forward to more contributions :)

Axect added a commit that referenced this pull request Jun 4, 2023
* Implement `Statistics` for `WeightedUniform` (#55)
* New trait and utils for specific precision floating point
Axect added a commit that referenced this pull request Jun 4, 2023
* Implement `Statistics` for `WeightedUniform` (#55)
* New trait and utils for specific precision floating point
@Axect
Copy link
Owner

Axect commented Jun 4, 2023

Now, I published new version 0.33.4, which includes your contribution. 😎
Thank you again for your great contribution!

Axect added a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants