[feature] Support complex matrix [2] #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added gecp and gepp for LU factorization using Gauss Elimination - Added Lin alg traits like determinant and inverse of a complex matrix
- Removed temporary FPComplexMatrix trait and added FPMatrix trait as generic that is used for Complex matrix too
- Removed temporary ComplexMutMatrix trait and added MutMatrix trait as generic that is used for Complex matrix too
- Use type Scalar to make Algorithms trait generic to be used by both Vector and ComplexVector - Only swap_with_perms() implemented for ComplexVector
- Added solve vec and solve matrix from Linalg trait
- Added traits for ComplexMatrix
- Instead of using similar functions for complex matrices, used generics for the functions in low_level.rs
- Added gecp and gepp for LU factorization using Gauss Elimination - Added Lin alg traits like determinant and inverse of a complex matrix
- Use type Scalar to make Algorithms trait generic to be used by both Vector and ComplexVector - Only swap_with_perms() implemented for ComplexVector
- Added solve vec and solve matrix from Linalg trait
- Added traits for ComplexMatrix
- Instead of using similar functions for complex matrices, used generics for the functions in low_level.rs
…ssue35 Backup 2nd cleanup complex issue35 is merged back
soumyasen1809
changed the base branch from
master
to
35-support-complex-number
Axect
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Approved. Thanks for your work on issue #35 for Complex Matrix support.
- Reviewed changes: traits successfully converted to generic, tests passing.
- Minor issue: some imports are from 'fuga' instead of base files. I'll fix this post-merge.
- Good work overall.
I want to sincerely apologize for the delay in reviewing your PRs. My recent schedule has been extremely demanding, but I assure you that your contributions are valued. I'm committed to reviewing your other PRs as soon as possible. Your patience and continued efforts are truly appreciated.
Ready to merge. Thank you for your valuable contribution.
Axect
added a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #35