Skip to content

Run black on all existing code #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaffney2010 opened this issue Apr 8, 2020 · 3 comments
Closed

Run black on all existing code #1312

gaffney2010 opened this issue Apr 8, 2020 · 3 comments

Comments

@gaffney2010
Copy link
Member

If we're using black to format, I'd prefer to run on existing code. If we format as we go it can be harder to see why we're changing something. It caused me some merge conflicts when I ran black, changing lines, which were unchanged in origin, then were changed.

@drvinceknight
Copy link
Member

I'm in favour.

We can add a check to the CI to check all files are in the required format (for example: https://github.com/drvinceknight/Nashpy/blob/master/.github/workflows/config.yml#L34).

We'd need to add something to the contribution docs as well.

Something to consider though is the relatively massive PR that @marcharper has on the go #1288 this would potentially make that really painful to sort out so it could be worth doing after that goes in.

@gaffney2010
Copy link
Member Author

Sounds good. I will work on after #1288 goes through.

@marcharper
Copy link
Member

#1288 is going to have a lot of merge conflicts anyway, and it's waiting on another PR, so feel free to work on whatever regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants