Skip to content

Run isort utility on all files #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaffney2010 opened this issue Apr 10, 2020 · 6 comments · Fixed by #1351
Closed

Run isort utility on all files #1326

gaffney2010 opened this issue Apr 10, 2020 · 6 comments · Fixed by #1351

Comments

@gaffney2010
Copy link
Member

Similar to #1312. The contribution guidelines should say this should be run on every file. We can run on all files and possibly add a check.

@drvinceknight
Copy link
Member

There might be a slight problem that arises, in my experience on other projects checking isort and black sometimes don't seem to agree (if I recall). If it works though I'm 100% in favour (and will need to go back to my other projects...)! (If we have to choose I think we go with black).

@akash-suresh
Copy link
Contributor

Hey! Can I pick this up? 😄

I have used isort, in one of my earlier projects. And this seems like a fairly simple task to get acquainted with the codebase.

@drvinceknight
Copy link
Member

Please do 👍

@akash-suresh
Copy link
Contributor

Hey @drvinceknight, I tried running the unit-test suite to make sure, its setup properly. A few of the test cases are failing. I am using Python 3.8.

@drvinceknight
Copy link
Member

Yeah there are a couple of tests that don't pass yet on py3.8 (#1315). If you setup a virtual environment with py3.7 you should be fine.

@akash-suresh
Copy link
Contributor

Oh alright. Thanks for the clarification. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants