-
Notifications
You must be signed in to change notification settings - Fork 271
Run isort utility on all files #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There might be a slight problem that arises, in my experience on other projects checking isort and black sometimes don't seem to agree (if I recall). If it works though I'm 100% in favour (and will need to go back to my other projects...)! (If we have to choose I think we go with black). |
Hey! Can I pick this up? 😄 I have used |
Please do 👍 |
Hey @drvinceknight, I tried running the unit-test suite to make sure, its setup properly. A few of the test cases are failing. I am using Python 3.8. |
Yeah there are a couple of tests that don't pass yet on py3.8 (#1315). If you setup a virtual environment with py3.7 you should be fine. |
Oh alright. Thanks for the clarification. 👍 |
Similar to #1312. The contribution guidelines should say this should be run on every file. We can run on all files and possibly add a check.
The text was updated successfully, but these errors were encountered: