Added volume widget #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
can this be merged? |
Contributor
|
What about a mute icon? |
Owner
|
Hi, sure! I'll merge, but I need to finish other things first. :) |
Contributor
Author
|
Im working on a click to mute+unmute function and making the icons change according to volume level. so maybe don't merge yet? |
Contributor
Author
|
Done. |
Owner
|
Great! I'll make some modifications because it doesn't follow the general structure of code and styling, but it works really well. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a widget to control the volume
You scroll up and down on the widget to adjust the volume and the circular progress bar shows the volume level.
Awesome project btw keep it going :)