Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotationPrefix from app-config #236

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Use annotationPrefix from app-config #236

merged 2 commits into from
Jan 9, 2025

Conversation

fridajac
Copy link
Contributor

@fridajac fridajac commented Dec 20, 2024

Hey, I just made a Pull Request!

The JiraDashboardContent now uses the annotationPrefix from the app-config file.

Changes:

Would like to remove the need of setting if={entity => isJiraDashboardAvailable(entity, 'jira')} at all in frontend, but will try to fix that in future PR.

Context

Using an alternative Jira annotation instead of 'jira.com' didn't work because JiraDashboardContent couldn't read the custom config annotationPrefix value, defaulting back to 'jira.com'. This has now been fixed.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have verified that my code follows the style already available in the repository
  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@fridajac fridajac requested a review from a team as a code owner December 20, 2024 10:23
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: cc2ce66

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

plugins/jira-dashboard/package.json Outdated Show resolved Hide resolved
@fridajac fridajac requested a review from anicke December 20, 2024 13:07
@anicke anicke self-requested a review January 9, 2025 14:18
@fridajac fridajac merged commit 82161b3 into main Jan 9, 2025
6 checks passed
@fridajac fridajac deleted the config-value branch January 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom annotationPrefix config no longer works and always defaults to 'jira.com'
2 participants