feat(button): danger and success variant #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekoaf
force-pushed
the
feat/danger_button
branch
from
9df3e95
to
cbcbc35
Compare
lekoaf
changed the title
Adds a "danger" variant which signifies a dangerous action, such as deleting a user. Adds a "success" variant which signifies a positive action. The change affects - Button - IconButton - IconTextButton This change also affects a number of snapshots. This because a primary button uses `textPrimary` and `elementPrimary` to change the color between for instance the normal and hover state. `textError` and `elementError` however had the exact same color. Had to add `textSuccess` since this color didn't exist at all, which seems like an error due to the fact that all other `element...` has an equivalent `text...`.
lekoaf
force-pushed
the
feat/danger_button
branch
from
cbcbc35
to
79506fc
Compare
|
I'm not sure if adding a color is classified as a breaking change or not. Let me know please. |
|
Got some ideas how to refactor the repetitive CSS too, but thought I'd do that in a separate PR instead. |
Tigge
force-pushed
the
main
branch
7 times, most recently
from
92874f3
to
4adee08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "danger" variant which signifies a dangerous action, such as deleting a user.
Adds a "success" variant which signifies a positive action.
The change affects
This change also affects a number of snapshots. This because a primary button uses
textPrimaryandelementPrimaryto change the color between for instance the normal and hover state.textErrorandelementErrorhowever had the exact same color.Had to add
textSuccesssince this color didn't exist at all, which seems like an error due to the fact that all otherelement...has an equivalenttext....