[#43] Replace CI Services for Test Containers and move to JUnit 5 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove JUnit4 dependency - Include JUnit5 dependencies - Change all import statements - Remove public keyword, as that's no longer required - Switch usages of expected exception to assertThrows - Introduce TestSerializer to allow for a secure XStreamSerializer instance in tests - Add javadoc to some for test clarity - Remove warnings whenever applicable - Add todos for items to pick up later #43
- Merge the two auto-config tests into one test class, which uses a local ApplicationContextRunner to switch between configurations - Define assertj and jackson test dependencies - Resolve warnings in the AMQPAutoConfiguration - Provide javadoc #43
Rewrite the SpringAMQPIntegrationTest to no longer use an auto configuration, but instead create the required beans in the setUp, using the RabbitMQContainer as the means for communication. #43
Utilize a RabbitMQContainer in the RabbitMQBenchmark class to allow for local benchmarking without being required to set up RabbitMQ yourself #43
Define the default security instances for the TestSerializer to ensure security is set up correctly #43
lfgcampos
approved these changes
Jan 4, 2021
Simply use artifact "junit-jupiter instead of separate arfects for JUnit5 #43
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does two things:
To that end, several adjustments have been made to the pom files to comply with the new JUnit version and Test Containers.
All test classes have thus been adjusted to use the new import statements, removing all public keywords (as they are no longer necessary) and replaced "expected exceptions" for
assertThrows. Test containers on the other end have only been added to theSpringAMQPIntegrationTestandRabbitMQBenchmarkclasses.Furthermore, the auto-configuration tests have been made up to date, by using an
ApplicationContextRunner(as this allows for easier control over the used context and properties). This has led to the removal of the two older test classes in favour for a singleAMQPAutoConfigurationTestclass.Whenever applicable, warnings have been resolved and JavaDoc has been included.
This pull request resolves #43