Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#286] Add spring-boot-devtools support #287

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Apr 19, 2023

As uncovered in #286, the applyEvent extension function does not work as intended when spring-boot-devtools is on the classpath of the project.
To fix this, I've included a spring-devtools.properties file which includes the axon-kotlin modules in its restarts.
To not be required to set a fixed JAR version, I've set resource filtering to true in the build settings of the pom.xml.

Include a spring-devtools.properties file to include axon-kotlin-*
modules in the restarts of devtools. To not have to set a fixed version,
 set resource filtering to true in the build settings of the pom.xml.

#feature/286-spring-boot-devtools-support
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit 65f60d5 into master Apr 19, 2023
@smcvb smcvb deleted the feature/286-spring-boot-devtools-support branch April 19, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants