[#35] Migrate project to start using testcontainers #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Dec 30, 2020
...nsions/mongo/eventsourcing/eventstore/MongoEventStorageEngineTest_DBObjectSerialization.java
Outdated
Show resolved
Hide resolved
Introduce a MongoTemplateFactory to reuse the functionality to construct a MongoTemplate based on a given host/port combination during testing. #35
|
Kudos, SonarCloud Quality Gate passed!
|
lfgcampos
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the usages of "flap doodle" as the means to run embedded Mongo in favour of using Test Containers.
As such, this PR changes the dependencies and the five tests (Saga, TokenStore and 3 EventStorageEngine tests) to use Mongo Test Containers.
These five tests used a mix of a custom
MongoLauncherand Spring to wire everything.Lastly, the
MongoLauncher(which used "flap doodle") and theMongoTestContextwere no longer used through these changes and thus have been removed.This PR resolves #35