Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/service.c: Drop MagnifierClosed signal handler #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src/service.c: Drop MagnifierClosed signal handler #39

wants to merge 1 commit into from

Conversation

tari01
Copy link
Member

@tari01 tari01 commented Aug 1, 2024

The greeter does not send this signal any longer.

@tari01 tari01 requested a review from sunweaver August 1, 2024 13:45
sunweaver
sunweaver requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@sunweaver sunweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain better (in the commit message) why we want to drop the MagnifierClosed signal handler.

@tari01
src/service.c: Drop MagnifierClosed signal handler: Since we have und…
5fd552e 
…ecorated the magnifier window, Arctica Greeter no longer sends the MagnifierClosed signal, so this code is now orphaned.
@tari01
Copy link
Member Author

tari01 commented Aug 26, 2024

Please explain better (in the commit message) why we want to drop the MagnifierClosed signal handler.

Done.

@tari01 tari01 requested a review from sunweaver August 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunweaver sunweaver Awaiting requested review from sunweaver

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tari01 @sunweaver