fix empty nodes #251

victorbrambati · 2022-10-31T02:06:25Z

I created the PR #242 but the updates created a conflict with my old PR. This PR solve the same problem, I tested the problems from #242 and it work correctly. Thank you for the patience.

AykutSarac · 2022-10-31T11:23:59Z

It works so great, thanks so much for that I'll be following up and testing this! Would you be able to make improvements for this to work? #181

victorbrambati · 2022-10-31T19:43:40Z

It works so great, thanks so much for that I'll be following up and testing this! Would you be able to make improvements for this to work? #181

Yes I created it now, but to not bug all UI of graph I put it only in objects out of an array, I don't know if the PR #181 is better choose, but to you compare I printed the graph:

Result of #181:

{ _id: "generated", field: "value", object: { fieldA: "valA", ObjectNestA: { fieldNestA: "valB", }, }, }

Result of the first example in #242:

{ "properties": { "definitions": { "type": "object", "additionalProperties": { "$dynamicRef": "#meta" }, "deprecated": true } } }

You want that I push this commit?

AykutSarac · 2022-11-01T08:00:30Z

Yes, please push the commit. II'll test it with more data and share my feedbacks with you.

AykutSarac · 2022-11-01T16:51:48Z

There's this issue, if there is a single object. The fields with string should be in a single node and rest should be connected to it. From this JSON it works very different that you will notice:

{
  "id": "AAL",
  "identifiers": [
    {
      "identifier": "AAL",
      "scheme": "SPDX"
    },
    {
      "identifier": "License :: OSI Approved :: Attribution Assurance License",
      "scheme": "Trove"
    }
  ],
  "links": [
    {
      "note": "OSI Page",
      "url": "https://opensource.org/licenses/AAL"
    }
  ],
  "name": "Attribution Assurance License",
  "other_names": [],
  "superseded_by": null,
  "keywords": [
    "osi-approved",
    "discouraged",
    "redundant"
  ],
  "text": [
    {
      "media_type": "text/html",
      "title": "HTML",
      "url": "https://opensource.org/licenses/AAL"
    }
  ]
}

How it looks in the PR:

How it should look:

I'm guessing it happens because nodes are created right after a line is read and not until whole object is did read?
You can compare PR with the existing version using the following json: https://api.opensource.org/licenses/

Thanks again for putting your effort into this, you will make a significant impact on this project :)

AykutSarac · 2022-11-01T16:53:17Z

For example for the default json, if I move one line to bottom the view changes:

{
  "squadName": "Super hero squad",
  "homeTown": "Metro City",
  "formed": 2016,
  "secretBase": "Super tower",
  "members": [
    {
      "name": "Molecule Man",
      "age": 29,
      "secretIdentity": "Dan Jukes",
      "powers": [
        "Radiation resistance",
        "Turning tiny",
        "Radiation blast"
      ]
    },
    {
      "name": "Madame Uppercut",
      "age": 39,
      "secretIdentity": "Jane Wilson",
      "powers": [
        "Million tonne punch",
        "Damage resistance",
        "Superhuman reflexes"
      ]
    },
    {
      "name": "Eternal Flame",
      "age": 1000000,
      "secretIdentity": "Unknown",
      "powers": [
        "Immortality",
        "Heat Immunity",
        "Inferno",
        "Teleportation",
        "Interdimensional travel"
      ]
    }
  ],
  "active": true
}

AykutSarac · 2022-11-01T17:09:42Z

Looks like when a parent node is collapsed and its parent is collapsed and expanded back, it's child disappears. Should be investigated later on after the parser is setup. This PR will make #161 possible ✨

victorbrambati · 2022-11-01T20:16:22Z

About this issue, is to make it too to fields with string that have parents? Because your example only have nodes that not have a parent.
Example:

{
  "one": {
    "sa": "sa",
    "si": "si",
    "right": {
      "example": "example"
    },
    "cg": "Cg"
  }
}

"sa": "sa", "si": "si" and "cg": "Cg" is to be the same node or "cg": "Cg" is to be separated of others in other node?

victorbrambati · 2022-11-01T20:18:43Z

Looks like when a parent node is collapsed and its parent is collapsed and expanded back, it's child disappears. Should be investigated later on after the parser is setup. This PR will make #161 possible sparkles

Amazing! ✨

AykutSarac · 2022-11-02T06:10:26Z

About this issue, is to make it too to fields with string that have parents? Because your example only have nodes that not have a parent. Example:
{
  "one": {
    "sa": "sa",
    "si": "si",
    "right": {
      "example": "example"
    },
    "cg": "Cg"
  }
}
"sa": "sa", "si": "si" and "cg": "Cg" is to be the same node or "cg": "Cg" is to be separated of others in other node?

No, what I mean here is when going through inside of an object e.g.

{
  "str1": "string",
  "array": ["hi", "ho"],
  "str2": "string2"
}

String values inside of an object should create a single object and rest should be seperated and connected same as how current jsoncrack.com works.

How it is:

How it should be:

victorbrambati · 2022-11-03T02:03:08Z

You want that the childrens of an object without a key into an array repeat the same behavior expected? (because in this new commit it doesn't happen)

AykutSarac · 2022-11-03T10:05:48Z

You want that the childrens of an object without a key into an array repeat the same behavior expected? (because in this new commit it doesn't happen)

Can you elaborate with example of data? I think with the latest commit all seems fine.

victorbrambati · 2022-11-03T23:00:31Z

Can you elaborate with example of data? I think with the latest commit all seems fine.

Yes, the commit 76bcad4 kept separated the brothers node in a object from array.

This example was obtained in: https://api.opensource.org/licenses/

[ { "id": "AAL", "identifiers": [ { "identifier": "AAL", "scheme": "SPDX" }, { "identifier": "License :: OSI Approved :: Attribution Assurance License", "scheme": "Trove" } ], "links": [ { "note": "OSI Page", "url": "https://opensource.org/licenses/AAL" } ], "name": "Attribution Assurance License", "other_names": [], "superseded_by": null, "keywords": [ "osi-approved", "discouraged", "redundant" ], "text": [ { "media_type": "text/html", "title": "HTML", "url": "https://opensource.org/licenses/AAL" } ] }, { "id": "AFL-3.0", "identifiers": [ { "identifier": "AFL-3.0", "scheme": "SPDX" }, { "identifier": "License :: OSI Approved :: Academic Free License (AFL)", "scheme": "Trove" } ], "links": [ { "note": "OSI Page", "url": "https://opensource.org/licenses/AFL-3.0" } ], "name": "Academic Free License, Version 3.0", "other_names": [], "superseded_by": null, "keywords": [ "osi-approved", "discouraged", "redundant" ], "text": [ { "media_type": "text/html", "title": "HTML", "url": "https://opensource.org/licenses/AFL-3.0" } ] } ]

commit 76bcad4:

new commit e772153:

victorbrambati · 2022-11-03T23:05:22Z

Now with the last commit e772153 all seems fine.

AykutSarac · 2022-11-04T18:35:24Z

Thank you Victor! Finally, I believe it would be a better UX experience to not have a root node if there's an array of object at root level independent of each other like in the https://api.opensource.org/licenses/

So, same as the current version can we keep them seperated without connections?

[
  {
    "id": "Zlib",
    "identifiers": [
      {
        "identifier": "Zlib",
        "scheme": "DEP5"
      },
      {
        "identifier": "Zlib",
        "scheme": "SPDX"
      },
      {
        "identifier": "License :: OSI Approved :: zlib/libpng License",
        "scheme": "Trove"
      }
    ],
    "links": [
      {
        "note": "OSI Page",
        "url": "https://opensource.org/licenses/Zlib"
      }
    ],
    "name": "The zlib/libpng License (Zlib)",
    "other_names": [],
    "superseded_by": null,
    "keywords": [
      "osi-approved"
    ],
    "text": [
      {
        "media_type": "text/html",
        "title": "HTML",
        "url": "https://opensource.org/licenses/Zlib"
      }
    ]
  },
  {
    "id": "jabberpl",
    "identifiers": [
      {
        "identifier": "License :: OSI Approved :: Jabber Open Source License",
        "scheme": "Trove"
      }
    ],
    "links": [
      {
        "note": "OSI Page",
        "url": "https://opensource.org/licenses/jabberpl"
      }
    ],
    "name": "Jabber Open Source License",
    "other_names": [],
    "superseded_by": null,
    "keywords": [
      "discouraged",
      "retired",
      "osi-approved"
    ],
    "text": [
      {
        "media_type": "text/html",
        "title": "HTML",
        "url": "https://opensource.org/licenses/jabberpl"
      }
    ]
  }
]

victorbrambati · 2022-11-04T19:53:03Z

@AykutSarac Yes. I will commit now.

AykutSarac · 2022-11-05T10:04:15Z

Awesome work @victorbrambati! Parser seems ready to be merged, now I'm investigate the collapse/expand issue and I'll commit whenever I find a solution. You may want to take a look if you have an idea.

{
  "ankara": {
    "name": "name",
    "username": "username",
    "password": "password",
    "servers": [
      {
        "ipaddress": "10.10.10.10",
        "listenport": 4222,
        "clusterport": 6112
      }
    ]
  }
}

victorbrambati · 2022-11-05T13:10:32Z

Awesome work @victorbrambati! Parser seems ready to be merged, now I'm investigate the collapse/expand issue and I'll commit whenever I find a solution. You may want to take a look if you have an idea.
{
  "ankara": {
    "name": "name",
    "username": "username",
    "password": "password",
    "servers": [
      {
        "ipaddress": "10.10.10.10",
        "listenport": 4222,
        "clusterport": 6112
      }
    ]
  }
}

It happen when a parent connect a parent directly, before that did not happen. Probrably is a problem in algorithm of a collapsed nodes that it was not thought to work in these circumstances.

victorbrambati · 2022-11-06T21:22:05Z

@AykutSarac I found a solution:

AykutSarac · 2022-11-07T07:40:36Z

Awesome work @victorbrambati, I'm merging this now with the main branch 🚀

fix empty nodes

24d9715

This was linked to issues Oct 31, 2022

Nesting issue dictionary with an Int and other dictionaries #51

Closed

[Bug] Nested objects causing empty nodes #27

Closed

feat: brothers node and parent node in the same parent

50cb490

This was linked to issues Nov 1, 2022

[BUG]: Yanlış Görselleştirme #154

Closed

Object with field and a nested object is shown as directed node #181

Closed

fix: different brother node for same parent object

76bcad4

AykutSarac mentioned this pull request Nov 3, 2022

Ability to copy path to node #198

Closed

fix: different brothers node in array is not work correctly

e772153

feat: don't create an empty node in a root array

36fcb6f

AykutSarac added the enhancement Improve performance or optimization label Nov 5, 2022

fix: collapsed parent node disappears when expand

b7492c1

chore: refactor getOutgoers

41743f1

AykutSarac merged commit 57389b3 into AykutSarac:main Nov 7, 2022

AykutSarac added the hacktoberfest-accepted label Nov 7, 2022

victorbrambati mentioned this pull request Nov 8, 2022

[BUG]: object member and array of one object member have same visual results #140

Closed

AykutSarac mentioned this pull request Nov 24, 2022

[BUG]: Siblings look like descendents #193

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix empty nodes #251

fix empty nodes #251

victorbrambati commented Oct 31, 2022

AykutSarac commented Oct 31, 2022

victorbrambati commented Oct 31, 2022 •

edited

Loading

AykutSarac commented Nov 1, 2022

AykutSarac commented Nov 1, 2022

AykutSarac commented Nov 1, 2022

AykutSarac commented Nov 1, 2022 •

edited

Loading

victorbrambati commented Nov 1, 2022 •

edited

Loading

victorbrambati commented Nov 1, 2022

AykutSarac commented Nov 2, 2022

victorbrambati commented Nov 3, 2022

AykutSarac commented Nov 3, 2022

victorbrambati commented Nov 3, 2022

victorbrambati commented Nov 3, 2022

AykutSarac commented Nov 4, 2022

victorbrambati commented Nov 4, 2022

AykutSarac commented Nov 5, 2022

victorbrambati commented Nov 5, 2022

victorbrambati commented Nov 6, 2022

AykutSarac commented Nov 7, 2022

fix empty nodes #251

fix empty nodes #251

Conversation

victorbrambati commented Oct 31, 2022

AykutSarac commented Oct 31, 2022

victorbrambati commented Oct 31, 2022 • edited Loading

AykutSarac commented Nov 1, 2022

AykutSarac commented Nov 1, 2022

AykutSarac commented Nov 1, 2022

AykutSarac commented Nov 1, 2022 • edited Loading

victorbrambati commented Nov 1, 2022 • edited Loading

victorbrambati commented Nov 1, 2022

AykutSarac commented Nov 2, 2022

victorbrambati commented Nov 3, 2022

AykutSarac commented Nov 3, 2022

victorbrambati commented Nov 3, 2022

victorbrambati commented Nov 3, 2022

AykutSarac commented Nov 4, 2022

victorbrambati commented Nov 4, 2022

AykutSarac commented Nov 5, 2022

victorbrambati commented Nov 5, 2022

victorbrambati commented Nov 6, 2022

AykutSarac commented Nov 7, 2022

victorbrambati commented Oct 31, 2022 •

edited

Loading

AykutSarac commented Nov 1, 2022 •

edited

Loading

victorbrambati commented Nov 1, 2022 •

edited

Loading